-
Notifications
You must be signed in to change notification settings - Fork 0
FMWK-816 Optimize S3 operations #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
filkeith
wants to merge
30
commits into
main
Choose a base branch
from
FMWK-816-s3-optimizations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some optimizations
- checksum fix
- disabled checksum
- no checksum on restore
- returned back checskum as it doesn't affect performance
94c806b to
0f4d896
Compare
- starting from scratch
0f4d896 to
e6e45b1
Compare
- test
- one more try
- buffer
- compare memory usage
- test with 2 workers
- test no sync pool
- copy
- nulify slice
- clean
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
==========================================
- Coverage 78.78% 78.56% -0.22%
==========================================
Files 105 107 +2
Lines 10537 10681 +144
==========================================
+ Hits 8302 8392 +90
- Misses 1739 1786 +47
- Partials 496 503 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- removed checksum validation on read
- fix single file backup
- test filepath for meta
- test single file backup with meta
- fix single file path
- fix single file backup
- fix range reader optimizations
# Conflicts: # io/storage/aws/s3/writer.go
- set default value for s3 concurrency 1
reugn
reviewed
Oct 22, 2025
- review fixes
- tests fix
# Conflicts: # state.go
reugn
reviewed
Oct 23, 2025
- review fixes
- small fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.