Move peer discovery from "services" to "peers-clear" #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas32
reviewed
May 10, 2022
src/cluster/peers.rs
Outdated
|
|
||
| #[test] | ||
| fn parse_peers_works() { | ||
| let work = "6,3000,[[12A0,aerospike.preprod.crto.in,[192.168.1.13:4333]],[11A1,aerospike.preprod.crto.in,[192.168.3.78]],[11A1,aerospike.preprod.crto.in,[localhost]]]"; |
There was a problem hiding this comment.
The used Hostnames and IPs look like real ones. Maybe change that to dummy addresses?
There was a problem hiding this comment.
IP were dummy but not the hostname indeed.
Changed them also corrected a bug where the tls_hostname is ommited
This is necessary to implement TLS as service only report the clear service port. It will be easy to expand the "services_name" to return peers-tls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to implement TLS as the "service" info only report the clear service port.
It will be easy to expand the "services_name" to return peers-tls
Required for #8