Skip to content

[CLIENT-3106] Convert POLICY_SET_FIELD() macro into an inline function #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

Makes POLICY_SET_FIELD() more readable, easier to debug, and it should have the same performance as a macro.

Extra changes:

  • Enable -Winline flag so we know if the compiler is actually making a function inline or not

TODO

  • Verify performance using perf regression tests
  • Add -Winline and -Werror flag to build-wheels.yml

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (cd0e783) to head (402f955).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/policy.c 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #802      +/-   ##
==========================================
- Coverage   82.00%   82.00%   -0.01%     
==========================================
  Files          99       99              
  Lines       14698    14718      +20     
==========================================
+ Hits        12053    12069      +16     
- Misses       2645     2649       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants