Skip to content

[CLIENT-3530] Change dynamic config interval to milliseconds between configuration reads #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[CLIENT-3530] Change dynamic config interval to milliseconds between configuration reads #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3dfd5d
update c client
juliannguyen4 Jun 23, 2025
ab841b4
update docs
juliannguyen4 Jun 24, 2025
6b78e97
update tests
juliannguyen4 Jun 24, 2025
da71f6d
Merge remote-tracking branch 'origin/dev' into CLIENT-3530-change-dyn…
juliannguyen4 Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aerospike-client-c
Open in desktop
Submodule aerospike-client-c updated 8 files
+1 −1 src/include/aerospike/as_cluster.h
+10 −4 src/include/aerospike/as_config.h
+6 −5 src/include/aerospike/as_partition_tracker.h
+13 −4 src/main/aerospike/aerospike_query.c
+25 −8 src/main/aerospike/aerospike_scan.c
+14 −2 src/main/aerospike/as_cluster.c
+41 −9 src/main/aerospike/as_config_file.c
+20 −11 src/main/aerospike/as_partition_tracker.c
4 changes: 3 additions & 1 deletion doc/config_provider.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ Methods

:param path: Dynamic configuration file path. Cluster policies will be read from the yaml file at cluster initialization and whenever the file changes. The policies fields in the file override all command policies.
:type path: str
:param interval: Check dynamic configuration file for changes after this number of cluster tend iterations. Defaults to ``60``.

:param interval: Interval in milliseconds between dynamic configuration check for file modifications.
The value must be greater than or equal to the tend interval. Defaults to ``60000``.
:type interval: int, optional

.. py:attribute:: path
Expand Down
2 changes: 1 addition & 1 deletion test/dyn_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ dynamic:
send_key: false
static:
client:
config_interval: 1
config_interval: 1000
8 changes: 4 additions & 4 deletions test/new_tests/test_dynamic_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@
class TestDynamicConfig:
def test_config_provider_defaults(self):
provider = aerospike.ConfigProvider(path="path")
assert provider.interval == 60
assert provider.interval == 60000

def test_config_provider_class(self):
provider = aerospike.ConfigProvider(path="path", interval=30)
provider = aerospike.ConfigProvider(path="path", interval=30000)

assert provider.path == "path"
assert provider.interval == 30
assert provider.interval == 30000
# Fields should be read only
with pytest.raises(AttributeError):
provider.path = "invalid"
with pytest.raises(AttributeError):
provider.interval = 10
provider.interval = 10000

def test_config_provider_class_invalid_args(self):
# See comment in test_mrt_api.py's test_transaction_class test case
Expand Down
Loading