Skip to content

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Jun 20, 2025

When building the Python client on Windows, statically link against the pthread library so the Python client's C code can make calls to functions in pthread.h. pthread is statically linked twice overall (against the C client and the Python client)

Valgrind shows no memory errors or leaks from these changes
Valgrind massif usage looks ok
Build artifacts passes except for noise in 1 job.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2025

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.07%. Comparing base (7256716) to head (a5abd4b).
⚠️ Report is 17 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/query/foreach.c 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #794      +/-   ##
==========================================
+ Coverage   81.92%   82.07%   +0.14%     
==========================================
  Files          99       99              
  Lines       14671    14680       +9     
==========================================
+ Hits        12019    12048      +29     
+ Misses       2652     2632      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-2417] query.foreach(): add mutex to avoid globbing err object across multiple threads [CLIENT-2417] query.foreach(): have each callback thread set its own as_error object to avoid overriding the main error Jul 1, 2025
@juliannguyen4 juliannguyen4 marked this pull request as ready for review July 9, 2025 02:24
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliannguyen4 juliannguyen4 merged commit 09512c3 into dev Jul 10, 2025
120 of 124 checks passed
@juliannguyen4 juliannguyen4 deleted the parakh-paginate-tmp branch July 10, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants