-
Notifications
You must be signed in to change notification settings - Fork 112
[CLIENT-2417] query.foreach(): have each callback thread set its own as_error object to avoid overriding the main error #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #794 +/- ##
==========================================
+ Coverage 81.92% 82.07% +0.14%
==========================================
Files 99 99
Lines 14671 14680 +9
==========================================
+ Hits 12019 12048 +29
+ Misses 2652 2632 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
revert formatting. make clang-format ignore pthread header file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
When building the Python client on Windows, statically link against the pthread library so the Python client's C code can make calls to functions in pthread.h. pthread is statically linked twice overall (against the C client and the Python client)
Valgrind shows no memory errors or leaks from these changes
Valgrind massif usage looks ok
Build artifacts passes except for noise in 1 job.