-
Notifications
You must be signed in to change notification settings - Fork 112
[CLIENT-3510] Add support for adding a PKI user without a password #787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-3510] Add support for adding a PKI user without a password #787
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #787 +/- ##
==========================================
+ Coverage 81.92% 82.00% +0.08%
==========================================
Files 99 99
Lines 14671 14698 +27
==========================================
+ Hits 12019 12053 +34
+ Misses 2652 2645 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…requests using pk
…ding-pki-user-without-password
…-config-interval-to-ms
…ding-pki-user-without-password
…terval-to-ms' into CLIENT-3510-support-adding-pki-user-without-password
…ead > config_interval even if dyn config is not enabled
de75175
to
d7107d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! In general this LGTM I just have a few things to run by you in the comments. Let me know when you've had a look.
Co-authored-by: dwelch-spike <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Manual testing
Build artifacts passes
Valgrind shows no mem leaks or errors from these changes
Massif memory usage looks ok
Docs
https://aerospike-python-client--787.org.readthedocs.build/en/787/client.html#aerospike.Client.admin_create_pki_user
https://aerospike-python-client--787.org.readthedocs.build/en/787/aerospike.html#:~:text=tend_interval,-(int
https://aerospike-python-client--787.org.readthedocs.build/en/787/aerospike.html#aerospike.AUTH_PKI
https://aerospike-python-client--787.org.readthedocs.build/en/787/config_provider.html#aerospike.ConfigProvider
Extra changes:
Notes:
TODO