Skip to content

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented May 5, 2025

TODO:

  • Figure out why pytest didn't report this error
  • PyObject_SetAttrString is raising an exception if an attribute is set to NULL and the attribute previously existed
  • Manual repro of attrs being deleted bug
  • Get exact test where this happens

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2025

Codecov Report

❌ Patch coverage is 73.07692% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.94%. Comparing base (f762c03) to head (d087e3b).
⚠️ Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/exception.c 73.07% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #769      +/-   ##
==========================================
- Coverage   82.03%   81.94%   -0.10%     
==========================================
  Files          99       99              
  Lines       14724    13929     -795     
==========================================
- Hits        12079    11414     -665     
+ Misses       2645     2515     -130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 marked this pull request as draft May 5, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants