Skip to content

[CLIENT-3434] Fix the wrong client config policy used for client.batch_{operate,apply,remove,write}() when a transaction-level batch policy is passed as an argument #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Apr 29, 2025

TODO:
docs, regression test

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (6ab075b) to head (822689d).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/client/batch_apply.c 0.00% 3 Missing ⚠️
src/main/client/batch_operate.c 0.00% 3 Missing ⚠️
src/main/client/batch_remove.c 0.00% 3 Missing ⚠️
src/main/client/batch_write.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #766       +/-   ##
==========================================
- Coverage   81.71%   0.00%   -81.72%     
==========================================
  Files          98      80       -18     
  Lines       14474   12633     -1841     
==========================================
- Hits        11827       0    -11827     
- Misses       2647   12633     +9986     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…rsing policies

Added documenation explaining when each default is used.
Added batch_parent_write as global default of batch_operate function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants