[CLIENT-3411] Refactor code that initializes transaction-level as_policy_batch policy using a Python dictionary #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-batch-policy-used-in-batch-write-commands-long-term-refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #756 +/- ##
==========================================
- Coverage 81.71% 0.00% -81.72%
==========================================
Files 98 5 -93
Lines 14474 1015 -13459
==========================================
- Hits 11827 0 -11827
+ Misses 2647 1015 -1632 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POLICY_INIT(): remove policy init step because we are already copying the default values from the config level policy to the transaction level policy. (TODO: check this does not cause regressions for other policies)
Set optional field variables to Python None by default. Setting them to NULL causes us to handle extra codepaths which is annoying to deal with