Skip to content

[CLIENT-3366] Add support for dynamic config #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 153 commits into from
May 13, 2025
Merged

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Mar 24, 2025

Extra changes

  • Fix all memory leaks coming from as_config object
  • aerospike.Client(): moved config initialization code earlier in the call to properly clean up as_config instance.
  • Add config level metrics policy to override latency* options
  • Bundle libyaml with wheels

Notes:

  • aerospike_s.dynamic_config property should be private so I did not expose it in the Python client

Manual testing

  • Build artifacts passes except for noise
  • Valgrind shows no memory errors coming from these changes.
  • Massif usage looks ok

Docs

https://aerospike-python-client--744.org.readthedocs.build/en/744/aerospike.html#:~:text=config_provider,-(aerospike.ConfigProvider
https://aerospike-python-client--744.org.readthedocs.build/en/744/aerospike.html#:~:text=metrics,-(MetricsPolicy
https://aerospike-python-client--744.org.readthedocs.build/en/744/config_provider.html#aerospike.ConfigProvider
https://aerospike-python-client--744.org.readthedocs.build/en/744/index.html#:~:text=module%20contains%20these-,classes

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 90.81633% with 9 lines in your changes missing coverage. Please review.

Project coverage is 81.78%. Comparing base (f978b29) to head (3c2fa6f).
Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/client/type.c 90.00% 4 Missing ⚠️
src/main/config_provider/type.c 89.18% 4 Missing ⚠️
src/main/conversions.c 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #744      +/-   ##
==========================================
+ Coverage   81.71%   81.78%   +0.06%     
==========================================
  Files          98       99       +1     
  Lines       14474    14551      +77     
==========================================
+ Hits        11827    11900      +73     
- Misses       2647     2651       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review May 12, 2025 20:58
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a few notes/nits. After you have had a look let me know and I'll approve.

@dwelch-spike dwelch-spike self-requested a review May 12, 2025 23:51
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliannguyen4 juliannguyen4 merged commit c0527a7 into dev May 13, 2025
27 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-3366-dyn-config branch May 13, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants