-
Notifications
You must be signed in to change notification settings - Fork 112
[CLIENT-3366] Add support for dynamic config #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #744 +/- ##
==========================================
+ Coverage 81.71% 81.78% +0.06%
==========================================
Files 98 99 +1
Lines 14474 14551 +77
==========================================
+ Hits 11827 11900 +73
- Misses 2647 2651 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…aerospike_enable_metrics
…tion to prevent this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just a few notes/nits. After you have had a look let me know and I'll approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Extra changes
Notes:
aerospike_s.dynamic_config
property should be private so I did not expose it in the Python clientManual testing
Docs
https://aerospike-python-client--744.org.readthedocs.build/en/744/aerospike.html#:~:text=config_provider,-(aerospike.ConfigProvider
https://aerospike-python-client--744.org.readthedocs.build/en/744/aerospike.html#:~:text=metrics,-(MetricsPolicy
https://aerospike-python-client--744.org.readthedocs.build/en/744/config_provider.html#aerospike.ConfigProvider
https://aerospike-python-client--744.org.readthedocs.build/en/744/index.html#:~:text=module%20contains%20these-,classes