-
Notifications
You must be signed in to change notification settings - Fork 112
[CLIENT-3161] Add client config option to validate keys passed into client config and policy dictionaries #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #729 +/- ##
==========================================
+ Coverage 82.03% 82.17% +0.14%
==========================================
Files 99 99
Lines 14724 14179 -545
==========================================
- Hits 12079 11652 -427
+ Misses 2645 2527 -118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
if (set_subpolicies(&config, py_policies) != AEROSPIKE_OK) { | ||
error_code = INIT_POLICY_PARAM_ERR; | ||
goto CONSTRUCTOR_ERROR; | ||
if (set_subpolicies(&constructor_err, &config, py_policies, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensure no breaking changes
Manual testing:
Code coverage shows all config keys are covered by tests
There may be a performance impact when creating a new client instance with validate_keys set to True, but that setting can be disabled in a production system.
Extra changes:
test/
Valgrind shows no memory errors
TODO
Notes (pls ignore):