Skip to content

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Feb 20, 2025

  • Allow toggling config["validate_keys"] in the regression tests. The performance tests must have this disabled since we are simulating production workloads.

Manual testing:

  • Code coverage shows all config keys are covered by tests

  • There may be a performance impact when creating a new client instance with validate_keys set to True, but that setting can be disabled in a production system.

Extra changes:

  • CI/CD: Build unoptimized client for running code coverage report for more accurate results
  • CI/CD: prevent flake8 from scanning the wrong files in test/
  • CLIENT-3493 client.{scan,query}apply()'s write policy will no longer be applied to aerospike{scan,query}_wait() as an info policy.

Valgrind shows no memory errors

TODO

  • Verify all config keys are covered in array... done
  • Transaction level policies do not raise an exception correctly.
  • Other txn-level policies do not validate keys yet.

Notes (pls ignore):

  • Idea: use hashmap to map keys to callbacks that set C client values

@juliannguyen4 juliannguyen4 changed the base branch from master to dev February 20, 2025 16:40
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

❌ Patch coverage is 88.07339% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.17%. Comparing base (f762c03) to head (a1a56fe).
⚠️ Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/client/type.c 85.29% 10 Missing ⚠️
src/main/aerospike.c 68.00% 8 Missing ⚠️
src/main/policy.c 74.19% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #729      +/-   ##
==========================================
+ Coverage   82.03%   82.17%   +0.14%     
==========================================
  Files          99       99              
  Lines       14724    14179     -545     
==========================================
- Hits        12079    11652     -427     
+ Misses       2645     2527     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 removed the request for review from rbotzer April 9, 2025 17:12
if (set_subpolicies(&config, py_policies) != AEROSPIKE_OK) {
error_code = INIT_POLICY_PARAM_ERR;
goto CONSTRUCTOR_ERROR;
if (set_subpolicies(&constructor_err, &config, py_policies,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure no breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants