-
Notifications
You must be signed in to change notification settings - Fork 6
Client 3872 add ci scripts #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
Conversation
mirzakaracic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great stab at it and should get you to release packages. The aerospike-client-java-reactive project is following similar dev workflow for shipping as most other clients other than python, that is PR -> stage -> main.
b5df09f to
cad18b9
Compare
| sign-artifacts: | ||
| needs: [build-packages, extract-version] | ||
| uses: aerospike/shared-workflows/.github/workflows/reusable_sign-artifacts.yaml@1c93424fa30c040b8420f4c3a5533b030bdc3865 | ||
| uses: aerospike/shared-workflows/.github/workflows/reusable_sign-artifacts.yaml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: take commit hash/branch name after workflow name
Would be possible to leave everything after the filename, aka @<version/branch name> since we have gh-workflows-ref? I have not tested this my self but seems repetitive to have the same information twice. It makes it confusing and error prone to have the same information in two different places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we cannot omit it, since it is from a different repository. Based on the docs:
You reference reusable workflow files using one of the following syntaxes:
{owner}/{repo}/.github/workflows/{filename}@{ref} for reusable workflows in public and private repositories. ./.github/workflows/{filename} for reusable workflows in the same repository.In the first option, {ref} can be a SHA, a release tag, or a branch name. If a release tag and a branch have the same name, the release tag takes precedence over the branch name. Using the commit SHA is the safest option for stability and security. For more information, see Secure use reference.
mirzakaracic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the commit hashes.
|
There is also a failing test. Could it be wrong project? |
This is expected. The correct URL expects a build number, like this: API_PATH="/api/build/aerospike-client-java-reactive/42?project=database" I was trying with enforcing the workflow to run on PR, with some hardcoded build number. It can be ignored now. |
is-snapshotnot available from build infoTesting:
Tested with commenting out all portions that could alter anything anywhere.
Latest can be seen here: https://github.com/aerospike/aerospike-client-java-reactive/actions/runs/20125452454/job/57754079729
The workflow is failing at later stages as it doesn't exist in
mainbranch.Actual run
First: a build and release should run on pushing to stage -> that should publish to internal JFrog
Second: when the build is done, manually this promote workflow can be triggered after adding a release tag to the stage branch