[Go] Fix to not allocate to the heap when iterating over repeating groups … #994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in golang 1.22
Verify by running
When compiling in Golang 1.22, the loop behavior has changed and the code generated by SBE in Go can suddenly allocate to the heap.
You can verify this by running
Before the generated could would look like
This reference to prop could potentially allocate if prop.Encode could not be inlined.
The new code that is generated uses the index to get the reference, which will not allocate.