-
Notifications
You must be signed in to change notification settings - Fork 237
[ENH] Implement series_to_series forecaster mixin #3146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
|
@hadifawaz1999 this PR is regarding the unimplemented |
hadifawaz1999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this. Few comments before going into details:
- Dummy forecaster should be under forecasring/deep_learning and should inherit base deep forecaster instead of base forecaster
|
@hadifawaz1999 the last few tests that are failing are in python 3.13 enviroment specifically, due to tensorflow compatibility issues. Tensorflow is being imported in |
Hello, for all tests you should add this decorator: @pytest.mark.skipif(
not _check_soft_dependencies("tensorflow", severity="none"),
reason="skip test if required soft dependency not available",
) |
Reference Issues/PRs
Fixes #2910
What does this implement/fix? Explain your changes.
This PR implements the Mixin class for
series_to_seriesforecasters by introducing a abstract method_series_to_series_forecast.A dummy series forecaster is also implemented in
_dummy_series_forecaster.pyfor testing purpose.Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access