-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT,ENH] Assign-bot (Allow users to type alternative phrases for assingment) #2704
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test this on your fork or show it is working some other way. We cannot test it here until this is merged.
Do you think it would be possible to create a test file for this? good thinking on the JSON file and |
I think I can create a test file for this, and assert_called_with is actually part of Python's unittest.mock module. Do you want me to create the test file in a separate PR?(Maybe we can use that to check/test other features of the bot). |
Give it a try here. only needs to be this file ofc |
The ideal method for testing this is just running it though. Unit tests are very welcome to make sure it keeps running, but only if they accurately capture whether it is working or not in the first place. See See #2703 |
Reference Issues/PRs
#2697
What does this implement/fix? Explain your changes.
allow users to assign themselves with more alternative phrases like: please assign me, assign me, can you assign this to me, i want to work on this, give me this issue (i.e no need to tag themselves)
users can also assign others by using phrase "assign"
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access