Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT,ENH] Assign-bot (Allow users to type alternative phrases for assingment) #2704

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Ramana-Raja
Copy link

@Ramana-Raja Ramana-Raja commented Mar 29, 2025

Reference Issues/PRs

#2697

What does this implement/fix? Explain your changes.

allow users to assign themselves with more alternative phrases like: please assign me, assign me, can you assign this to me, i want to work on this, give me this issue (i.e no need to tag themselves)

users can also assign others by using phrase "assign"

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@Ramana-Raja Ramana-Raja requested a review from a team as a code owner March 29, 2025 12:12
@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement maintenance Continuous integration, unit testing & package distribution labels Mar 29, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$, $\color{#EC843A}{\textsf{maintenance}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@Ramana-Raja Ramana-Raja changed the title [MNT,ENH] Allow users to type alternative phrases for assingment [MNT,ENH] Assign-bot (Allow users to type alternative phrases for assingment) Mar 29, 2025
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test this on your fork or show it is working some other way. We cannot test it here until this is merged.

@Ramana-Raja
Copy link
Author

Ramana-Raja commented Apr 4, 2025

Please test this on your fork or show it is working some other way. We cannot test it here until this is merged.

here is a code from which I tested this feature:
image

json file:
image

output:
image

does not work when wrong input given:
image

output:
image

@MatthewMiddlehurst
Copy link
Member

Do you think it would be possible to create a test file for this? good thinking on the JSON file and assert_called_with, did not know that existed! Is that part of the github package?

@Ramana-Raja
Copy link
Author

Do you think it would be possible to create a test file for this? good thinking on the JSON file and assert_called_with, did not know that existed! Is that part of the github package?

I think I can create a test file for this, and assert_called_with is actually part of Python's unittest.mock module. Do you want me to create the test file in a separate PR?(Maybe we can use that to check/test other features of the bot).

@MatthewMiddlehurst
Copy link
Member

Give it a try here. only needs to be this file ofc

@MatthewMiddlehurst
Copy link
Member

The ideal method for testing this is just running it though. Unit tests are very welcome to make sure it keeps running, but only if they accurately capture whether it is working or not in the first place.

See See #2703

@Ramana-Raja
Copy link
Author

The ideal method for testing this is just running it though. Unit tests are very welcome to make sure it keeps running, but only if they accurately capture whether it is working or not in the first place.

See See #2703

Hi, I created a test PR ,everything seems to be working perfectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants