Custom base path (fix #3874, related to #3535) #4792
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is a duplicate of #4381 |
Author
Maybe there is something wrong with the previous attempt, since it has not been merged yet. |
Contributor
|
I am not a maintainer, but I don't think duplicates are any good. You can leave a comment there, but duplicate PRs do just add extra review. PRs just take longer sometimes. It's not uncommon. If something is wrong with the PR advplyr would wrote it Edit: / Make a PR to their repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
Tries to make a customizable ROUTE_BASE_PATH.
Which issue is fixed?
Fixes #3874
It is related to the discussion #3535