Fix broken component tests #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah we can add it to the workflow |
|
OK, added the workflow:
|
|
I tested this and it looks good, is there anything else you wanted to add here? |
|
No, just forgot to mark it as ready for review. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
This fixes some broken client component tests
Which issue is fixed?
No issue.
In-depth Description
Unfortunately, we don't run component tests automatically, so they break from time to time.
This fixes them to run with the current code.
If it's OK with you, I'll add these to the push procedure using a Github workflow (like unit tests).
How have you tested this?
All existing tests run.