Fix Book/Podcast updateFromRequest to support null values in string f…

…ields #3938
advplyr · Feb 5, 2025 · 24d6e39 · 24d6e39
1 parent 0cf7a6a
commit 24d6e39
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/server/models/Book.js b/server/models/Book.js
@@ -365,7 +365,7 @@ class Book extends Model {
     if (payload.metadata) {
       const metadataStringKeys = ['title', 'subtitle', 'publishedYear', 'publishedDate', 'publisher', 'description', 'isbn', 'asin', 'language']
       metadataStringKeys.forEach((key) => {
-        if (typeof payload.metadata[key] === 'string' && this[key] !== payload.metadata[key]) {
+        if ((typeof payload.metadata[key] === 'string' || payload.metadata[key] === null) && this[key] !== payload.metadata[key]) {
           this[key] = payload.metadata[key] || null
 
           if (key === 'title') {

diff --git a/server/models/Podcast.js b/server/models/Podcast.js
@@ -202,8 +202,9 @@ class Podcast extends Model {
         } else if (key === 'itunesPageUrl') {
           newKey = 'itunesPageURL'
         }
-        if (typeof payload.metadata[key] === 'string' && payload.metadata[key] !== this[newKey]) {
-          this[newKey] = payload.metadata[key]
+        if ((typeof payload.metadata[key] === 'string' || payload.metadata[key] === null) && payload.metadata[key] !== this[newKey]) {
+          this[newKey] = payload.metadata[key] || null
+
           if (key === 'title') {
             this.titleIgnorePrefix = getTitleIgnorePrefix(this.title)
           }