Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to implement SolidBodyNearlyIncompressibleX #640

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Feb 20, 2024

  • this works for disconnected dual meshes
  • but not for connected dual meshes

I guess it's because the volume-matrices are not invertible for connected meshes.

I'm not sure if it's worth the effort for disconnected meshes only...

@adtzlr adtzlr added the enhancement New feature or request label Feb 20, 2024
@adtzlr adtzlr self-assigned this Feb 20, 2024
@adtzlr adtzlr marked this pull request as draft February 20, 2024 16:04
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 25.85034% with 109 lines in your changes missing coverage. Please review.

Project coverage is 94.91%. Comparing base (3ecf1a3) to head (f64797b).
Report is 890 commits behind head on main.

Files Patch % Lines
...rc/felupe/mechanics/_solidbody_incompressible_x.py 17.34% 81 Missing ⚠️
src/felupe/mechanics/_helpers.py 25.00% 27 Missing ⚠️
src/felupe/field/_dual.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   97.07%   94.91%   -2.17%     
==========================================
  Files          94       95       +1     
  Lines        4752     4896     +144     
==========================================
+ Hits         4613     4647      +34     
- Misses        139      249     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adtzlr adtzlr mentioned this pull request Feb 20, 2024
6 tasks
@adtzlr adtzlr changed the title Second attempt for SolidBodyNearlyIncompressibleX Attempt to implement SolidBodyNearlyIncompressibleX Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant