-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added failing test: ClientPutFile_ZeroByteFile #2
Conversation
The changes look good. Are you able to fix the failing tests? It's been a while since I worked on the project. I believe they worked using a recording of a real session and played back the underlying http messages. |
I just added another commit which fixes the issue. Thank you. |
…when running tests
Prevent infinite loop from OperationTimeout
Fixed failing test
For some reason, the session recorded for the new test |
Does it repro locally for you? We can modify the targets if needed. |
Yes, I can reproduce the issue locally. Should I remove netcoreapp3.1 and net5.0? |
Sure we can deprecate those if they are causing you trouble.
If that's useful for you feel free. Or you can add net9.0. |
Removed netcoreapp3.1 and net5.0 Added net8.0 and net9.0
Looks like the build is passing. If you want to flip this off draft we can get this merged. I'll take a crack at publishing the package this weekend. |
Thank you! |
Thanks for your contribution. Happy you find it of use. |
No description provided.