Allow a arbitrary equality comparison function to be passed in the column options #1132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
#1131
β Type of change
π Description
Lucid uses 'fast-deep-equal' for comparing values to track changes
As per the package documentation: https://github.com/epoberezkin/fast-deep-equal
Lucid does not use the es6 version, so comparing Sets always considers them equal, and as such will not save the changes.
We could use the es6 version with a minimal impact on performance, but I think this approach of allow custom equality comparators to be passed in is more flexible.
With my implementation it would allow custom equality comparison between currency objects, sets, or other custom data structures.
I will update the docs soon as I've gotten some feedback on this PR.
π Checklist