feature: add sqlite support #14
Conversation
|
Hello @thetutlage, could you please take a look at this? |
| @@ -20,6 +20,7 @@ | |||
| "test": "npm run test:pg && npm run test:mysql && mkdir coverage/tmp && cp -r coverage/*/tmp/. coverage/tmp && c8 report", | |||
| "test:pg": "cross-env DB=pg c8 --reporter=json --report-dir=coverage/pg npm run quick:test", | |||
| "test:mysql": "cross-env DB=mysql c8 --reporter=json --report-dir=coverage/mysql npm run quick:test", | |||
| "test:sqlite": "cross-env DB=sqlite c8 --reporter=json --report-dir=coverage/sqlite npm run quick:test", | |||
There was a problem hiding this comment.
This script should be added to the Github workflows for tests to run for SQLite
|
Can you please fix the type-checking errors? https://github.com/adonisjs/limiter/pull/14/files#file-tests-define_config-spec-ts-L166 |
|
@thetutlage Hi, I've addressed the comments. However, it looks like the |
|
I see the SQLite tests are failing. Can you please look into them? |
We can replace it with the |
Hello @thetutlage Redis was missing in the test-sqlite job, which seemed to be the reason the tests were failing. I've added it now, and it should be resolved. Let me know if everything looks good. |
❓ Type of change
📚 Description
This PR upgrades
node-rate-limiter-flexibleto the latest version, which includes SQLite support. It also updates the store configuration to integrate SQLite as a supported option.Background
Our project uses SQLite as the main database, and some features require rate limiting. To enable this, I contributed SQLite support to
node-rate-limiter-flexible. With this update, we can now leverage SQLite as a storage backend for rate limiting within this Adonis package.Changes
node-rate-limiter-flexibleto the latest versionTesting
Let me know if any adjustments or improvements are needed!