Skip to content

Gnorton/badge and progress circle to barebones poc #5786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: barebones
Choose a base branch
from
Draft

Gnorton/badge and progress circle to barebones poc #5786

wants to merge 7 commits into from
+1,332 −1,178

Conversation

rubencarvalho
Copy link
Contributor

Description

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@graynorton
chore: merge S2 badge migration
a637fef 
Squashed commit of the following:

commit e1d5a14
Author: castastrophe <[email protected]>
Date:   Fri Sep 19 11:32:26 2025 -0400

    chore: remove progress-circle into separate PR

commit 3c029d0
Author: castastrophe <[email protected]>
Date:   Wed Sep 3 16:25:15 2025 -0400

    chore: adding docs notes and todos to 2nd gen

commit c6bed3c
Author: castastrophe <[email protected]>
Date:   Wed Sep 3 15:02:13 2025 -0400

    fix(badge): separate S1/S2 API in alternate approach

commit 6b7f5d2
Author: castastrophe <[email protected]>
Date:   Wed Sep 3 14:43:48 2025 -0400

    fix(badge,progress-circle): remove modifiers

commit 43f9c90
Author: castastrophe <[email protected]>
Date:   Wed Sep 3 13:18:12 2025 -0400

    feat(badge): s2 styling and render brought in
@graynorton
chore: merge S2 progress-circle migration
b922d3e 
Squashed commit of the following:

commit 059fbd3
Author: castastrophe <[email protected]>
Date:   Wed Sep 3 16:25:15 2025 -0400

    chore: adding docs notes and todos to 2nd gen

commit 540aa52
Author: castastrophe <[email protected]>
Date:   Wed Sep 3 15:02:13 2025 -0400

    fix(badge): separate S1/S2 API in alternate approach

commit b812a70
Author: castastrophe <[email protected]>
Date:   Wed Sep 3 14:43:48 2025 -0400

    fix(badge,progress-circle): remove modifiers

commit 2c4821b
Author: castastrophe <[email protected]>
Date:   Wed Sep 3 13:18:12 2025 -0400

    feat(badge): s2 styling and render brought in
@graynorton
chore: don't bundle any lit dependencies
87f0e67
@graynorton
chore: add storybook-helpers, re-enable CEM build
4623a86
@graynorton
chore: make valid sizes accessible as a static prop
74be4da
@graynorton
chore: update badge to match barebones patterns
aaf9832
@graynorton
chore: update progress-circle to match barebones patterns
bf2dc81
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: bf2dc81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubencarvalho @graynorton