-
Notifications
You must be signed in to change notification settings - Fork 234
docs(slider,meter,progressbar,dropzone,illustratedmessage): migration roadmap #5775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(slider,meter,progressbar,dropzone,illustratedmessage): migration roadmap #5775
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor question, but this looks awesome! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping comments for the first 4 components, will do slider separately in a little bit!
|
||
## Summary of changes | ||
|
||
### CSS => SWC implementation gaps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a color to the track seems to be supported in CSS (Legacy & S2) but since I think it's done through inline styles, I'm not sure it really counts as an implementation gap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean this control CSS has, where we can add a custom slider track color?

I think I agree that it's not really an implementation gap- as long as we have the correct CSS cascade, consumers should be able to set the track color similarly, right? However, when I try this in SWC storybook, with style="--spectrum-slider-track-color: linear-gradient(red, blue);"
, only part of the track fill (and actually the unfilled track) gets the custom color.

Think I should just mention at so it's on our radar, to verify the right behavior when we migrate? That's where I'm leaning now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, when I try this in SWC storybook, with style=“--spectrum-slider-track-color: linear-gradient(red, blue);“, only part of the track fill (and actually the unfilled track) gets the custom color.
Ahhh. I thought that was the intended behavior but I think it may not be. It looks like the track doesn't need to be filled in S1, but the way we did the S2 migration, it looks like that's not an option. The designs portray a fill most of the time, but the offset variant does show some unfilled sliders.
The Storybook control, I think, has been setting the color on the custom property for the unfilled part of the track since S1, but since we didn't always fill the track it wasn't as noticeable. The gradient example on the S1 docs page is unfilled.
Since it is doable but does get more complicated to do custom track colors if the track should always be filled, that'd be a good thing to clarify with design one way or the other, so yeah, I think it would be spot-on to mention it so we can verify it when we're migrating.
|
||
</details> | ||
|
||
### CSS => SWC mapping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing the precise (handle) variant, it's new for S2! On the table and in the summary.
9e7a40d
to
ff74e36
Compare
0beabc0
to
710afb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
db0a7b2
into
2nd-gen-component-analysis
Description
Creates AI-generated migration documentation to analyze component differences to guide SWC migration to S2, with human vetting. The documentation serves as a bridge between the migrated Spectrum 2 CSS work and the corresponding web components, in order to help engineers understand what needs to be implemented, updated, or aligned between the two systems to guide the development of 2nd generation web components.
This batch is for the components: Meter, Progress bar, Slider, Illustrated message, Drop zone.
Motivation and context
Related issue(s)
SWC-1219
Screenshots (if appropriate)
Author's checklist
I have added automated tests to cover my changes.I have included a well-written changeset if my change needs to be published.Reviewer's checklist
patch
,minor
, ormajor
featuresManual review test cases
Documentation Quality
Cross-Reference Accuracy
metadata.json
filesDevice review