Skip to content

fix(sp-link): normal and quiet focus-visible states #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TiffanyAltieri
Copy link

Description

This PR fixes an sp-link issue in which the focus indicator is not shown for quiet links.

Motivation and context

This changes fixes an accessibility issue with quiet sp-link - it now shows proper focus

Related issue(s)

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Test focus on quiet sp-link on desktop Safari

    1. Open storybook from this PR
    2. Add query param to the end of the URL ?path=/story/link--quiet
    3. Try to tab to the quiet sp-link with the physical keyboard
  • Test focus on quiet sp-link on iOS (MAY WORK)

    1. Open storybook from this PR on an iPad with a physical keyboard attached
    2. Add query param to the end of the URL ?path=/story/link--quiet
    3. Try to tab to the quiet sp-link with the physical keyboard

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@TiffanyAltieri TiffanyAltieri requested a review from a team as a code owner August 16, 2025 03:36
Copy link

changeset-bot bot commented Aug 16, 2025

⚠️ No Changeset found

Latest commit: ab7ad52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant