-
Notifications
You must be signed in to change notification settings - Fork 233
fix(menu): no focus on first item if no selected items #5678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, you should reference the original GitHub issue (#5610) on the PR description.
Second, from that very ticket:
This is likely due to the modal overlay's focus trapping behavior (focusing on the first focusable element).
Menu should ALWAYS focus on an item when it receives focus. Not all overlays should autofocus.
Description
Motivation and context
Fixes the focus behavior to only set focus on selected items when the overlay is opened via click, as requested.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
featuresManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review