chore: compare compiled output fixes #3616
Conversation
🦋 Changeset detectedLatest commit: b3d2aa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
File metricsSummaryTotal size: -* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-3616--spectrum-css.netlify.app |
castastrophe
force-pushed
the
chore-compare-compiled-output
branch
6 times, most recently
from
809c192 to
05bfea3
Compare
| @@ -331,22 +331,16 @@ async function run() { | |||
| 0 | |||
| ); | |||
| core.setOutput("total-size", headMainSize); | |||
|
|
|||
| if (hasBase) { | |||
There was a problem hiding this comment.
We want to output the has-changed value whether there's a base or not - this ensures has-changed is reflected every time this script is run and the logic matches that used above to report in the comment if changes occurred.
| @@ -7,6 +7,13 @@ | |||
| "options": { | |||
| "printWidth": 500 | |||
| } | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Standardizing the Github Action spacing to mimic more what we have in use today and to align with a lot of the examples for GitHub Actions that exist.
castastrophe
force-pushed
the
chore-compare-compiled-output
branch
4 times, most recently
from
99448c8 to
9afcbe6
Compare
castastrophe
force-pushed
the
chore-compare-compiled-output
branch
from
9afcbe6 to
dafd056
Compare
castastrophe
force-pushed
the
main
branch
10 times, most recently
from
c68f4e3 to
d2272ea
Compare
castastrophe
force-pushed
the
chore-compare-compiled-output
branch
2 times, most recently
from
92504d4 to
489c55a
Compare
castastrophe
added
the
size-2 S
castastrophe
force-pushed
the
chore-compare-compiled-output
branch
8 times, most recently
from
a2daba1 to
63732ea
Compare
castastrophe
force-pushed
the
chore-compare-compiled-output
branch
11 times, most recently
from
9229191 to
24e2295
Compare
castastrophe
force-pushed
the
chore-compare-compiled-output
branch
from
24e2295 to
19e84d6
Compare
📚 Branch previewPR #3616 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-3616/index.html. |
Co-authored-by: rise-erpelding <[email protected]> Co-authored-by: [ Cassondra ] <[email protected]>
castastrophe
force-pushed
the
chore-compare-compiled-output
branch
5 times, most recently
from
176f399 to
f8e3702
Compare
castastrophe
force-pushed
the
chore-compare-compiled-output
branch
from
f8e3702 to
b3d2aa3
Compare
Description
This cleans up a bit of the rendering for the compiled compare tool that lets us see any changes to the compiled output so that changes caused by updates to tooling do not get missed during review.
Why does this update remove the netlify.toml?
To build this view for PRs separately from our storybook deploy, we need to maintain different base directories and commands in netlify. This is done more easily in the Netlify UI than it is handled in our local *.toml asset. It also adds an additional layer of security to ensure updates made to these configs are handled by authenticated users.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
yarn compareExpect this command to build all CSS components and open an HTML preview listing file sizes with a badge identifying components with changes. Components will be listed on the side navigation for easier navigation through all the data.To-do list