feat: add configuration management APIs and extend audit toggle to organizations #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
added 12 commits
October 29, 2025 16:33
ravverma
requested changes
Nov 11, 2025
| throw new Error('Context required'); | ||
| } | ||
| const { dataAccess } = ctx; | ||
| const { dataAccess, log } = ctx; |
Contributor
There was a problem hiding this comment.
seem log added but not used ?
| } | ||
|
|
||
| configuration.updateQueues(queues); | ||
| await configuration.save(); |
Contributor
There was a problem hiding this comment.
before saving suggested to set updatedBy
see reference in siteController
| return badRequest('Configuration data is required and cannot be empty'); | ||
| } | ||
|
|
||
| const hasHandlers = configData.handlers !== undefined; |
Contributor
There was a problem hiding this comment.
use hasText for this everywhere
| const site = await Site.findByBaseURL(baseURL); | ||
| if (site === null) { | ||
| return { status: 404, message: `Site with baseURL: ${baseURL} not found.` }; | ||
| const isSiteOperation = baseURL !== undefined; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive API endpoints for managing SpaceCat configurations and extends the audit toggle functionality to support organization-level operations.
Changes Made
New API Endpoints
Enhanced Endpoints
checkConfigurationorganizationIdController Changes (
src/controllers/configuration.js)updateQueuesmethod with validationupdateJobmethod with job type validationupdateHandlermethod with handler property validationupdateConfigurationmethod for flexible partial updatesgetLatestmethodrestoreVersion()methodgetByVersion()method to parse URL parameters correctlyController Changes (
src/controllers/sites-audits-toggle.js)validateInputto accept eitherbaseURLororganizationIdexecuteto handle both site-level and organization-level operationsRoutes (
src/routes/index.js)PUT /configurations/latest/queuesPATCH /configurations/latest/jobs/:jobTypePATCH /configurations/latest/handlers/:handlerTypePUT /configurations/latest→PATCH /configurations/latestOpenAPI Documentation
configuration-api.yamlwith all new endpoints and schema changesconfigurations-sites-audits-api.yamlto document organization-level supportTests
Dependencies
This PR depends on the spacecat-shared PR that exports the
checkConfigurationfunction and adds the configuration model methods.Testing
Please ensure your pull request adheres to the following guidelines:
describe here the problem you're solving.
If the PR is changing the API specification:
yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
If the PR is changing the API implementation or an entity exposed through the API:
If the PR is introducing a new audit type:
Related Issues
https://jira.corp.adobe.com/browse/LLMO-908
Thanks for contributing!