Skip to content

Conversation

@snowystinger
Copy link
Member

Closes

Adds links to our RAC pages for the underlying hooks used to build those components.

Is the mobile experience ok? it's a bit bare.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

import {InlineAlert, Heading, Content} from '@react-spectrum/s2'

export const tags = ['hint', 'popup', 'info'];
export const relatedPages = [{'title': 'useTooltipTrigger', 'url': 'https://react-spectrum.adobe.com/react-aria/useTooltipTrigger.html'}, {'title': 'useTooltip', 'url': 'https://react-spectrum.adobe.com/react-aria/useTooltip.html'}];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useTooltip doesn't exist, it is part of the useTooltipTrigger page, I'll go and update this

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, IMO the mobile experience is fine, no need to add more content since related pages is just a collection of links, hopefully the link titles are explanatory enough

@rspbot
Copy link

rspbot commented Nov 18, 2025

@rspbot
Copy link

rspbot commented Nov 18, 2025

@rspbot
Copy link

rspbot commented Nov 18, 2025

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:EditableCell

+EditableCell {
+  action?: string | FormHTMLAttributes<HTMLFormElement>['action']
+  align?: 'start' | 'center' | 'end' = 'start'
+  children: ReactNode
+  colSpan?: number
+  id?: Key
+  isSaving?: boolean
+  onCancel?: () => void
+  onSubmit?: (FormEvent<HTMLFormElement>) => void
+  renderEditing: () => ReactNode
+  showDivider?: boolean
+  textValue?: string
+}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants