Skip to content

fix: add missing data attributes to ColorField #9105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix: add missing data attributes to ColorField #9105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/react-aria-components/src/ColorField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,9 @@ function useChildren(
slot={props.slot || undefined}
data-channel={props.channel || 'hex'}
data-disabled={props.isDisabled || undefined}
data-invalid={validation.isInvalid || undefined} />
data-invalid={validation.isInvalid || undefined}
data-readonly={props.isReadOnly || undefined}
Copy link
Member

@snowystinger snowystinger Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, these should be added to the useRenderProps above as well, see an example here

react-spectrum/packages/react-aria-components/src/TextField.tsx

Line 110 in 8e7a57d

isReadOnly: props.isReadOnly || false,

we'll also want to have tests for this which can be modelled after

react-spectrum/packages/react-aria-components/test/TextField.test.js

Line 113 in 8e7a57d

it('should support read-only state', async () => {

data-required={props.isRequired || undefined} />
</Provider>
);
}