Skip to content

chore: remove horizontal card from ai export#10217

Merged
LFDanLu merged 1 commit into
mainfrom
remove-horizontal-card-export
Jun 17, 2026
Merged

chore: remove horizontal card from ai export#10217
LFDanLu merged 1 commit into
mainfrom
remove-horizontal-card-export

Conversation

@snowystinger

Copy link
Copy Markdown
Member

Closes

Release audit. Removing until design settles a bit more and we are ready for an s2 release as well so that we can make changes to the CardPreview API to support both so we don't have to copy the component which would lead to confusion.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot

rspbot commented Jun 17, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Jun 17, 2026

Copy link
Copy Markdown
## API Changes

@react-spectrum/ai

/@react-spectrum/ai:BasicHorizontalCard

-BasicHorizontalCard {
-  children: ReactNode | (HorizontalCardRenderProps) => ReactNode
-  density?: 'compact' | 'regular' | 'spacious' = 'regular'
-  download?: boolean | string
-  href?: Href
-  hrefLang?: string
-  id?: Key
-  isDisabled?: boolean
-  onAction?: () => void
-  onPress?: (PressEvent) => void
-  onPressChange?: (boolean) => void
-  onPressEnd?: (PressEvent) => void
-  onPressStart?: (PressEvent) => void
-  onPressUp?: (PressEvent) => void
-  ping?: string
-  referrerPolicy?: HTMLAttributeReferrerPolicy
-  rel?: string
-  routerOptions?: RouterOptions
-  size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
-  styles?: StyleString
-  target?: HTMLAttributeAnchorTarget
-  textValue?: string
-  value?: T
-  variant?: 'primary' | 'secondary' | 'tertiary' | 'quiet' = 'primary'
-}

/@react-spectrum/ai:CardPreview

-CardPreview {
-  children: ReactNode
-  id?: string
-  styles?: StyleString
-}

/@react-spectrum/ai:HorizontalCard

-HorizontalCard {
-  children: ReactNode | (HorizontalCardRenderProps) => ReactNode
-  density?: 'compact' | 'regular' | 'spacious' = 'regular'
-  download?: boolean | string
-  href?: Href
-  hrefLang?: string
-  id?: Key
-  isDisabled?: boolean
-  onAction?: () => void
-  onPress?: (PressEvent) => void
-  onPressChange?: (boolean) => void
-  onPressEnd?: (PressEvent) => void
-  onPressStart?: (PressEvent) => void
-  onPressUp?: (PressEvent) => void
-  ping?: string
-  referrerPolicy?: HTMLAttributeReferrerPolicy
-  rel?: string
-  routerOptions?: RouterOptions
-  size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
-  styles?: StyleString
-  target?: HTMLAttributeAnchorTarget
-  textValue?: string
-  value?: T
-  variant?: 'primary' | 'secondary' | 'tertiary' = 'primary'
-}

/@react-spectrum/ai:HorizontalCardProps

-HorizontalCardProps {
-  children: ReactNode | (HorizontalCardRenderProps) => ReactNode
-  density?: 'compact' | 'regular' | 'spacious' = 'regular'
-  download?: boolean | string
-  href?: Href
-  hrefLang?: string
-  id?: Key
-  isDisabled?: boolean
-  onAction?: () => void
-  onPress?: (PressEvent) => void
-  onPressChange?: (boolean) => void
-  onPressEnd?: (PressEvent) => void
-  onPressStart?: (PressEvent) => void
-  onPressUp?: (PressEvent) => void
-  ping?: string
-  referrerPolicy?: HTMLAttributeReferrerPolicy
-  rel?: string
-  routerOptions?: RouterOptions
-  size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
-  styles?: StyleString
-  target?: HTMLAttributeAnchorTarget
-  textValue?: string
-  value?: T
-  variant?: 'primary' | 'secondary' | 'tertiary' = 'primary'
-}

/@react-spectrum/ai:BasicCardProps

-BasicCardProps {
-  children: ReactNode | (HorizontalCardRenderProps) => ReactNode
-  density?: 'compact' | 'regular' | 'spacious' = 'regular'
-  download?: boolean | string
-  href?: Href
-  hrefLang?: string
-  id?: Key
-  isDisabled?: boolean
-  onAction?: () => void
-  onPress?: (PressEvent) => void
-  onPressChange?: (boolean) => void
-  onPressEnd?: (PressEvent) => void
-  onPressStart?: (PressEvent) => void
-  onPressUp?: (PressEvent) => void
-  ping?: string
-  referrerPolicy?: HTMLAttributeReferrerPolicy
-  rel?: string
-  routerOptions?: RouterOptions
-  size?: 'XS' | 'S' | 'M' | 'L' | 'XL' = 'M'
-  styles?: StyleString
-  target?: HTMLAttributeAnchorTarget
-  textValue?: string
-  value?: T
-  variant?: 'primary' | 'secondary' | 'tertiary' | 'quiet' = 'primary'
-}

@LFDanLu LFDanLu added this pull request to the merge queue Jun 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 17, 2026
@LFDanLu LFDanLu added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit 003d04d Jun 17, 2026
30 checks passed
@LFDanLu LFDanLu deleted the remove-horizontal-card-export branch June 17, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants