feat: Keyboard shortcuts#10200
Open
snowystinger wants to merge 5 commits into
Open
Conversation
|
Build successful! 🎉 |
## API Changes
@react-aria/interactions/@react-aria/interactions:KeyboardProps KeyboardProps {
+ allowComposing?: boolean
+ allowRepeats?: boolean
isDisabled?: boolean
onKeyDown?: (KeyboardEvent) => void
onKeyUp?: (KeyboardEvent) => void
+ shortcuts?: KeyboardShortcutBindings
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
I think I've solved the chaining issue we had. By using
chain, each handler is wrapped in it's own createEventHandler. This means that if any of the handlers or shortcuts call stopPropagation, it'll be stopped, same with preventDefault. They can't interfere with each other and the stricter behaviour wins. Stricter behaviour === stopping propagation and preventing of default.In addition, I fixed a couple issues where I didn't quite translate the old behaviour correctly.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: