Fix typos in training documentation - #4
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
Correct 20 spelling and grammar errors across the README, matrix and instructor/student module documents. Documentation only, no changes to training content or meaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 20 spelling and grammar typos found while reading through the training
material. Documentation only - no changes to the training content or its meaning.
README.md
The instructor welcome the students->welcomes(subject/verb agreement)explaining how would they do it->how they would do it(indirect question order)each team would expose how would they proceed->how they would proceedfor different purposes that the ones described->than the ones describedinstructor/module-01.md
Therefor we need to measure->Thereforetherefor it makes sense to elaborate->thereforethe use case that allows to check whether->allows checking whetherinstructor/module-02.md
### Come with the initial go-live strategy->### Come up with the initial go-live strategyinstructor/module-03.md
With the MVP implement, deployed->implementedinstructor/module-04.md
to a increasing number of clients->an increasingWhat communication channel are going to make available->What communication channels are we going to make availableinstructor/module-07.md
Be very clear on what do they need to do->what they need to doinstructor/module-08.md
different SLA agreement with different clients->agreementsbelow reponse time Threshold->responseinstructor/module-09.md
the continuously evolving the API->the continuously evolving API(duplicated article)clients that refuse the migrate->refuse to migrateone of the possible approach how to handle->one of the possible approaches to handlestudent/module-01.md
issues or complains around deliveries->complaintsmatrix.md
Monitor de transition->Monitor the transitionDimensions of sucess->successCome with the initial go-live strategy->Come up with ...to stay in sync with the module-02 heading aboveTwo hunks worth a closer look:
(
#come-with-the-initial-go-live-strategy->#come-up-with-...). Happy to dropthat hunk (and the matching matrix.md row) if you would rather keep the anchor stable.
instructor/module-04.mdline 32 needed a subject as well as the plural, so it readsWhat communication channels are we going to make available, matching theHow are we going to ...bullets around it.Branch name and commit message follow the adidas contribution guidelines
(bugfix/ kebab-case branch, infinitive-verb commit title under 40 chars).