fix: update timeout tests to match TaskExecutor error result behavior #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed timeout handling tests in
error-scenarios.test.jsto correctly expect error results (success: false) instead of thrown exceptions.Background
The tests were expecting
TaskExecutorto throwTaskTimeoutErrorexceptions, but the implementation actually catches all exceptions internally and returns standardized error results via theTaskResultinterface.Why CI was passing: These tests are marked as "slow tests" and skipped in CI via
skip: process.env.CI(line 17 of the test file). The failures only occurred in local development.Changes
Updated 4 timeout-related tests:
Test Results
All timeout tests now pass in local development:
Architecture Verification
✅ Confirmed this is the correct protocol design:
TaskExecutor.tsline 489: ThrowsTaskTimeoutErrorinternallyTaskExecutor.tsline 215: Catches all errors in public APITaskExecutor.tsline 766-788: Converts toTaskResultwithsuccess: falseRelated Issues
Changeset
🤖 Generated with Claude Code