Reimplement drag fill #3766
Merged
Reimplement drag fill #3766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
commented
Apr 21, 2025
| @@ -391,7 +392,6 @@ export function DataGrid<R, SR = unknown, K extends Key = Key>(props: DataGridPr | |||
| /** | |||
| * refs | |||
| */ | |||
| const latestDraggedOverRowIdx = useRef(draggedOverRowIdx); | |||
There was a problem hiding this comment.
No longer needed as we are using react event handlers
Comment on lines
+748
to
+752
| const offset = | ||
| scrollTop - | ||
| headerAndTopSummaryRowsHeight + | ||
| event.clientY - | ||
| gridEl.getBoundingClientRect().top; |
There was a problem hiding this comment.
Is there a better way?
| @@ -1056,7 +1124,6 @@ export function DataGrid<R, SR = unknown, K extends Key = Key>(props: DataGridPr | |||
| gridRowStart, | |||
| selectedCellIdx: selectedRowIdx === rowIdx ? selectedIdx : undefined, | |||
| draggedOverCellIdx: getDraggedOverCellIdx(rowIdx), | |||
There was a problem hiding this comment.
We can probably add another div and get rid of draggedOverCellIdx
package.json
Outdated
| @@ -68,8 +68,8 @@ | |||
| "@typescript-eslint/eslint-plugin": "^8.29.0", | |||
| "@typescript-eslint/parser": "^8.29.0", | |||
| "@vitejs/plugin-react": "^4.3.4", | |||
| "@vitest/browser": "^3.1.1", | |||
| "@vitest/coverage-v8": "^3.1.1", | |||
| "@vitest/browser": "3.1.1", | |||
There was a problem hiding this comment.
resizable tests fail in the latest version
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3766 +/- ##
==========================================
- Coverage 98.82% 98.67% -0.16%
==========================================
Files 47 46 -1
Lines 3499 3468 -31
Branches 766 762 -4
==========================================
- Hits 3458 3422 -36
- Misses 41 46 +5
🚀 New features to boost your workflow:
|
nstepien
previously approved these changes
Apr 24, 2025
Co-authored-by: Nicolas Stepien <[email protected]>
nstepien
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3215
This PR fixes a few issues with drag fill
mouseenterevent to find the dragged over row which does not work if the pointer is outside the grid. The new logic uses mouse coordinates andfindRowIdx.scrollIntoViewto fix itFF has a bug which results in cell selection change on drag
https://bugzilla.mozilla.org/show_bug.cgi?id=1961462