Update column width calculation logic

[amanmahajan7]

#3746 (comment)

I have removed clampColumnWidth helper and now the browser handle the minWidth/maxWidth using the following logic

• Use clamp/max when possible
• Use minmax when possible
• Fallback to minWidth/maxWidth on the measuring cell

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.69%. Comparing base (56a420e) to head (96887bb).

Files with missing lines	Patch %	Lines
src/hooks/useColumnWidths.ts	89.18%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3747      +/-   ##
==========================================
- Coverage   98.80%   98.69%   -0.12%     
==========================================
  Files          47       47              
  Lines        3424     3436      +12     
  Branches      743      750       +7     
==========================================
+ Hits         3383     3391       +8     
- Misses         41       45       +4     

Files with missing lines	Coverage Δ
src/HeaderCell.tsx	97.23% <100.00%> (-0.03%)	⬇️
src/hooks/useCalculatedColumns.ts	100.00% <100.00%> (ø)
src/utils/index.ts	90.47% <ø> (-3.08%)	⬇️
src/hooks/useColumnWidths.ts	96.32% <89.18%> (-2.77%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Wroud]

I believe that this function is not needed at all if we pass min-width and max-width to columns styles; then setting any width will not break the grid layout

[amanmahajan7]

This is needed to fix this bug. We already set min/max width on the measuring cell

[amanmahajan7]

It is possible that a column has a width less than minWidth or greater than maxWidth so we may have more or less viewport columns initially but they will be updated once the actual width is measured. I think this scenario is unlikely so I removed clampColumnWidth. getColumnWidthForMeasurement handles it using css clamp function now. I am okay with adding it back if you prefer

[amanmahajan7]

Cannot inline this function as exhaustive deps rule complains. I can add useMemo but not sure it is worth

[nstepien]

Do we need to handle maxWidth here if we set it on measuring cells?

[amanmahajan7]

Not 100% sure. My understanding is that grid computes the column widths and then apply min/max style from the measuring cell. This is the reason there was some left over space in the bug you found. I will check again

[amanmahajan7]

Also, resizing does not work properly without this as clampColumnWidth helper was removed

[amanmahajan7]

Found another edge case.