Skip to content

Conversation

@oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jul 24, 2025

fixes #29

Fix

  • Reverted changes to broken intersection queries

Update

  • isAvailableInHierarchy to account for detached models
  • sets sorted by .order
  • removed the word raw throughout and changed for more accurate names, availableComponents etc
  • removed the word sub throughout, from subset, and changed for more accurate names, set, getSet.., etc
  • generally refactor code so that logic is more distinct and easier to read
  • split scoringset into interactionset, lifecycleset and scoringset
  • adaptmodelset extends interactionset,
  • lifecycleset extends interactionset
  • isolate the compatibility layer
  • automatically assign set ids
  • formalise State and Objective apis
  • formalise lifecycle phases and triggers for init, restore, start, reset, restart, visit, leave and update, fully integrating adapt-contrib-modifiers
  • add order for lifecycle elements so that adapt-contrib-banking, adapt-contrib-randomise and adapt-contrib-scoringAssessment can execute in order, ordering sets appropriately
  • separate utility functions into appropriate files
  • add jsdocs throughout

New

  • added multiple functions to account for detached models
  • added TotalSets to replace the set behaviour on the main Adapt.scoring API
  • document INTERSECTION_QUERY.md
  • document LIFECYCLE.md

Breaking

  • Almost every function has been renamed or moved

@cahirodoherty-learningpool
Copy link
Contributor

Conflicts need resolved on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Reviewing

Development

Successfully merging this pull request may close these issues.

Version 2

4 participants