Skip to content

Fix: Make _renderAsGroup as typegroup=group (fixes #212) #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Make _renderAsGroup as typegroup=group (fixes #212) #213

wants to merge 2 commits into from

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Mar 25, 2025 •
edited
Loading

fixes #212

requires adaptlearning/adapt-contrib-core#645

Fix

  • Allow core router to treat a group as a sub-part of the parent contentobject rather than as a main contentobject

@oliverfoster oliverfoster self-assigned this Mar 25, 2025
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Mar 25, 2025
@oliverfoster oliverfoster requested a review from joe-replin March 25, 2025 19:01
@oliverfoster oliverfoster mentioned this pull request Mar 25, 2025
Open
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-replin joe-replin Awaiting requested review from joe-replin

Assignees

@oliverfoster oliverfoster

Labels
bug
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BoxMenu groups - show in plp and render phantom sub-menu when clicked
2 participants
@oliverfoster @cahirodoherty-learningpool