Refactor: Update dependencies, migrate to korlibs, and improve build #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate to `korlibs` library from `soywiz` for image and crypto handling. - Update project's dependencies to latest versions, including: - Kotlin to 2.1.0 - Spotless to 6.25.0 - Dokka to 1.9.10 - Kotlinx.datetime to 0.5.0 - Kotlinx.serialization to 1.6.2 - Kotlinx.coroutines to 1.7.3 - Ktor to 2.3.7 - Spark to 2.9.4 - Korlibs to 4.0.10 - Android Spotify auth to 1.2.6 - Android crypto to 1.1.0-alpha06 - AndroidX compat to 1.6.1 - Android Retrofuture to 1.7.4 - Refactor code to use `korlibs` classes and functions. - Replace use of `com.soywiz` packages with `korlibs`. - Update `settings.gradle.kts` to remove unnecessary logic. - Update `build.gradle.kts` to use `libs.version.toml`. - Update to Java 21. - Remove use of `launch` from `korio`. - Update Android compile SDK to 35 and minimum SDK to 23. - Add support for `publishAllPublicationsToNexusRepositoryWithTests` task. - Create `packForXcode` task to correctly compile and prepare for iOS compilation. - Add explicit `jvmToolchain` versions. - Migrate to the new kotlin `plugins` DSL. - Use `when` instead of `if` for clarity in `settings.gradle.kts`. - Use idiomatic Kotlin DSL wherever possible. - Remove unused imports. - Reorder imports by type. - Switch from `id()` to `alias()` in `plugins` block. - Correct plugin loading and versioning. - Remove unused repositories. - Migrate to using `libs.versions.toml` to declare all dependencies and plugins. - Remove `buildscript` and unnecessary references. - Added `applyDefaultHierarchyTemplate()` to `kotlin` block.
…pload action - Update Java version to 21 in all GitHub Actions workflows (release, ci-client, ci). - Update the `actions/upload-artifact` action version from v2 to v4.
…d on commonTest for commonJvmLikeTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming PR introduces several quality-of-life improvements to the library. These updates were necessary due to existing parsing issues, such as the inability to correctly parse the Spotify tracks pagination response. They are not fixed! It's just a pre-patch PR.
This pull request includes various updates to the project, primarily focusing on upgrading Java versions in CI workflows, updating Gradle plugin and library versions, and refactoring import statements for consistency. The most important changes are summarized below:
CI Workflow Updates:
ci-client.yml,ci.yml, andrelease.ymlworkflows. [1] [2] [3] [4] [5] [6]actions/upload-artifactfrom v2 to v4 inci-client.yml,ci.yml, andrelease.ymlworkflows. [1] [2] [3]Gradle Configuration Updates:
gradle/libs.versions.tomlto manage plugin and library versions.settings.gradle.ktsfor better readability and idiomatic Kotlin DSL usage.Dependency Refactoring:
korlibsinstead ofcom.soywizfor consistency across multiple files. [1] [2] [3] [4] [5] [6] [7] [8] [9]