Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minSDK to 21 as compose as #42

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Set minSDK to 21 as compose as #42

merged 4 commits into from
Dec 9, 2024

Conversation

adamglin0
Copy link
Owner

@adamglin0 adamglin0 commented Dec 7, 2024 •
edited
Loading

No description provided.

@adamglin0 adamglin0 linked an issue Dec 7, 2024 that may be closed by this pull request
Support Android API < 28 #1
Open
@adamglin0 adamglin0 changed the title Remove minSDK and targetSDK Set minSDK to 21 as compose as Dec 7, 2024
Skaldebane
Skaldebane requested changes Dec 7, 2024
View reviewed changes
compose-shadow/build.gradle.kts Outdated Show resolved Hide resolved
@adamglin0 adamglin0 requested a review from Skaldebane December 7, 2024 13:11
Skaldebane
Skaldebane reviewed Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@Skaldebane Skaldebane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One last thing though, was this tested on an unsupported device? Just to make sure that it doesn't crash.

@adamglin0
Copy link
Owner Author

adamglin0 commented Dec 7, 2024 •
edited
Loading

LGTM!
One last thing though, was this tested on an unsupported device? Just to make sure that it doesn't crash.

Just make sure no crash. The feature that support android21 is working in #43.

citytexi
citytexi approved these changes Dec 8, 2024
View reviewed changes
Copy link
Collaborator

@citytexi citytexi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Just curious - what's the reason for setting min to 21?

@Skaldebane
Copy link
Collaborator

@citytexi It's to support every version Compose itself supports. This is a UI library for Compose, so it kinda makes sense.

While the default KMP templates sets the minSdk to SDK 24 by default, most of androidx supports SDK 21 just fine (some even lower), and there's not much UI-wise that is different on Android 5 compared to, say, Android 7, so it's not a maintenance hurdle if you're already trying to support Android 7.

It might make sense for an app, but a library should always strive to maximize compatibility, so apps get to make the choice. Even as a no-op.

@adamglin0 adamglin0 merged commit 4fab980 into main Dec 9, 2024
9 checks passed
@adamglin0 adamglin0 deleted the 1-support-android-api-28 branch December 9, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skaldebane Skaldebane Skaldebane approved these changes

@citytexi citytexi citytexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Android API < 28
3 participants
@adamglin0 @Skaldebane @citytexi