Update deprecated calls to HostAndPort.getHostText()
#389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getHostText` method is deprecated, and scheduled for deletion. Although LittleProxy continues to support Java 7, using this deprecated method causes it to fail when used to Guava 23 (the latest release) Fortunately, `getHost` returns exactly the same value and is present in the latest releases.
Contributor
Author
|
Java 7 has been dead for a long time, and Java 9 is coming, but I'm offering this as an alternative to #388 |
xtj7
approved these changes
Aug 25, 2017
xtj7
left a comment
xtj7
left a comment
There was a problem hiding this comment.
Same as in PR 388, we really need it to work in projects with more recent Guava versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getHostTextmethod is deprecated, and scheduledfor deletion. Although LittleProxy continues to
support Java 7, using this deprecated method causes
it to fail when used to Guava 23 (the latest release)
Fortunately,
getHostreturns exactly the same valueand is present in the latest releases.