shared-bindings/traceback/__init__.c: check args more carefully; enhnce doc - #11209
Open
dhalbert wants to merge 1 commit into
Open
shared-bindings/traceback/__init__.c: check args more carefully; enhnce doc#11209dhalbert wants to merge 1 commit into
dhalbert wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks the args to make sure both
valueandtbare passed as args, or neither. Explains this in the documentation. The type signature of the functions can't really be expressed completely, since it's conditional on what's supplied, but I've tried to improve it slightly.Adds tests to
traceback_test.pyto verify the arg checks.