mpconfig: Use RUN_BACKGROUND_TASKS as the micropython event hook #10379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a newer abstraction in micropython; it'll for instance allow background tasks to be checked once per ms in the internal select module modselect. Because `MICROPY_INTERNAL_EVENT_HOOK` is used in a few locations, our own CIRCUITPY-CHANGE call to `RUN_BACKGROUND_TASKS` can be nixed. Specifically, `mp_event_handle_nowait` calls `MICROPY_INTERNAL_EVENT_HOOK` so paths from it don't need `RUN_BACKGROUND_TASKS` anymore.
|
I will be doing a MicroPython merge soon so I think I will wait on this a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a newer abstraction in micropython; it'll for instance allow background tasks to be checked once per ms in the internal select module modselect.
Because
MICROPY_INTERNAL_EVENT_HOOKis used in a few locations, our own CIRCUITPY-CHANGE call toRUN_BACKGROUND_TASKScan be nixed. Specifically,mp_event_handle_nowaitcallsMICROPY_INTERNAL_EVENT_HOOKso paths from it don't needRUN_BACKGROUND_TASKSanymore.However, while I'm traveling, I don't have access to hardware, so this is actually untested.