Skip to content

Add RP2 support for dma_capable #10240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Add RP2 support for dma_capable #10240

merged 1 commit into from
Apr 10, 2025

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Apr 8, 2025

This places the VM heap in PSRAM by default. audio_dma now directly allocates its buffers to ensure they are dma_capable.

@tannewt
Add RP2 support for dma_capable
abb3e93 
This places the VM heap in PSRAM by default. audio_dma now directly
allocates its buffers to ensure they are dma_capable.
@tannewt tannewt requested a review from dhalbert April 10, 2025 18:25
@tannewt tannewt marked this pull request as ready for review April 10, 2025 19:03
dhalbert
dhalbert approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and was an easier change than I thought. But it will reduce performance on boards with PSRAM -- I wonder by how much. We may need to revisit this in some way.

@tannewt tannewt merged commit b9f631e into adafruit:main Apr 10, 2025
614 checks passed
@relic-se relic-se mentioned this pull request Apr 15, 2025
Closed
relic-se added a commit to relic-se/circuitpython that referenced this pull request Apr 21, 2025
@relic-se
Revert changes in adafruit#10240 for RP2040.
ba9e809
@relic-se relic-se mentioned this pull request Apr 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert