Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Feather ESP32v2 Analog Pins incorrect #125 #126

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fixes Feather ESP32v2 Analog Pins incorrect #125 #126

merged 1 commit into from
Nov 9, 2023

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Nov 7, 2023

Fixes #125

@tyeth
Copy link
Contributor Author

tyeth commented Nov 7, 2023

@lorennorman what's the consequence of merging this, do backend things need to be tweaked?

lorennorman
lorennorman approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@lorennorman lorennorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship this whenever you're ready!

@tyeth tyeth merged commit 214b91e into main Nov 9, 2023
7 checks passed
@tyeth tyeth deleted the hotfix-esp32v2-analog-pins branch November 9, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorennorman lorennorman lorennorman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feather ESP32v2 Analog Pin backend names are incorrect - broken functionality
2 participants
@tyeth @lorennorman