DO NOT MERGE - Flush after debug prints, except SAMD (flush routine too big for SAMD21) #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
force-pushed
the
ws_printer_flush_but_samd_no_flush_recheck_esp8266
branch
from
2c614b4 to
efe0475
Compare
|
@tyeth Is this stale? |
|
This still has some utility, there is a missing PRINT HEX define when debug is off, and the flushes maybe useful, but now the SAMD block would need removing. Not sure if we want this or not. |
|
I think we can close for now, re-open down the line if we need extra debug help for SAMD21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
### DO NOT MERGE
Retest esp8266 and confirm SAMD51 prints device info