Skip to content

Commit 01ccd73

Browse files
committed
removed duplicated code
1 parent 6b79301 commit 01ccd73

File tree

5 files changed

+10
-269
lines changed

5 files changed

+10
-269
lines changed

include/ada.h

-1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,5 @@
3434
// Public API
3535
#include "ada/ada_version.h"
3636
#include "ada/implementation.h"
37-
#include "ada/implementation-inl.h"
3837

3938
#endif // ADA_H

include/ada/implementation-inl.h

-266
This file was deleted.

include/ada/parser.h

+4
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ extern template url_aggregator parse_url_impl<url_aggregator>(
5151
extern template url parse_url_impl<url>(std::string_view user_input,
5252
const url* base_url);
5353

54+
tl::expected<url_pattern, url_pattern_errors> parse_url_pattern_impl(
55+
std::variant<std::string_view, url_pattern_init> input,
56+
const std::string_view* base_url, const url_pattern_options* options);
57+
5458
} // namespace ada::parser
5559

5660
#endif // ADA_PARSER_H

src/implementation.cpp

+6-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#include "ada/url.h"
66
#include "ada/url_aggregator.h"
77
#include "ada/url_pattern.h"
8-
#include "ada/implementation-inl.h"
98

109
namespace ada {
1110

@@ -80,4 +79,10 @@ ada_warn_unused std::string to_string(ada::encoding_type type) {
8079
}
8180
}
8281

82+
ada_warn_unused tl::expected<url_pattern, url_pattern_errors> parse_url_pattern(
83+
std::variant<std::string_view, url_pattern_init> input,
84+
const std::string_view* base_url, const url_pattern_options* options) {
85+
return parser::parse_url_pattern_impl(std::move(input), base_url, options);
86+
}
87+
8388
} // namespace ada

src/parser.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -898,7 +898,6 @@ result_type parse_url_impl(std::string_view user_input,
898898
return url;
899899
}
900900

901-
template <>
902901
tl::expected<url_pattern, url_pattern_errors> parse_url_pattern_impl(
903902
std::variant<std::string_view, url_pattern_init> input,
904903
const std::string_view* base_url, const url_pattern_options* options) {

0 commit comments

Comments
 (0)