Skip to content

Commit 6b79301

Browse files
committed
complete inputs parsing
1 parent 64c7810 commit 6b79301

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

tests/wpt_urlpattern_tests.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -241,24 +241,22 @@ tl::expected<ada::url_pattern, ada::url_pattern_errors> parse_pattern(
241241

242242
std::variant<std::string, ada::url_pattern_init> parse_inputs_array(
243243
ondemand::array& inputs) {
244-
size_t index = 0;
245-
ada::url_pattern_init result{};
246-
247244
std::cout << "inputs: " << inputs.raw_json().value() << std::endl;
248245
inputs.reset();
249246

250247
for (auto input : inputs) {
251-
if (input.type() == ondemand::json_type::string && index == 0) {
248+
if (input.type() == ondemand::json_type::string) {
252249
std::string_view value;
253250
EXPECT_FALSE(input.get_string().get(value));
254251
return std::string(value);
255252
}
256253

257-
// TODO: Construct url_pattern_result here
258-
index++;
254+
ondemand::object attribute;
255+
EXPECT_FALSE(input.get_object().get(attribute));
256+
return parse_init(attribute);
259257
}
260258

261-
return result;
259+
return ada::url_pattern_init{};
262260
}
263261

264262
TEST(wpt_urlpattern_tests, urlpattern_test_data) {

0 commit comments

Comments
 (0)