Handle skipped stale coverage uploads - #25
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The behavioral change aligns with the stated API convention and is covered by targeted tests; remaining feedback is a minor warning-message quality improvement.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates the upload action’s response handling to support a new API convention where a 200 response with no upload ID indicates a stale commit upload that should be skipped (job succeeds without waiting for processing), while still treating missing IDs on 201 as an error.
Changes:
- Adjust
handle_responseto return an optional upload ID and treat200without an ID as a “skipped” upload (warning + early success). - Update main flow to only wait for processing when an upload ID is present.
- Add/adjust tests and document the skipped-stale behavior in the README.
File summaries
| File | Description |
|---|---|
| upload_coverage.py | Implements “skipped stale upload” behavior and propagates optional upload ID to processing wait logic. |
| test_upload_coverage.py | Adds coverage for 200-without-id skip behavior and telemetry reporting expectations. |
| README.md | Documents the new skipped-stale-commit behavior and its effect on waiting and exit code. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
jkbschmid
reviewed
Aug 6, 2026
jkbschmid
previously approved these changes
Aug 6, 2026
cassiomarques
force-pushed
the
cassiomarques/hnadle-skipped-stale-upload
branch
from
August 6, 2026 12:11
f075c85 to
e59685b
Compare
jkbschmid
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how the coverage upload action interprets the responses received from the monolith API.
The intent is to fix the bug without introducing breaking changes to the API. New installs of the upload action will no longer present the issue, whilst existing installs can be fixed by updating the version of the action (although we can't force users to do so automatically).