Skip to content

Fix SapMachine early-access filtering - #1217

Merged
brunoborges merged 6 commits into
actions:mainfrom
jdubois:jdubois-fix-sapmachine-ea-filtering
Aug 5, 2026
Merged

Fix SapMachine early-access filtering#1217
brunoborges merged 6 commits into
actions:mainfrom
jdubois:jdubois-fix-sapmachine-ea-filtering

Conversation

@jdubois

@jdubois jdubois commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make SapMachine GA and EA candidate filtering mutually exclusive
  • classify both boolean and string forms of the SapMachine ea metadata
  • add a deterministic fixture where a newer GA candidate previously won an EA request
  • regenerate the setup distribution bundle

Validation

Closes #1216

jdubois added 2 commits August 5, 2026 15:32
Ensure SapMachine EA requests exclude stable releases and cover string and boolean release metadata with competing fixture candidates.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Regenerate the setup bundle for SapMachine release-class filtering.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jdubois
jdubois requested a review from a team as a code owner August 5, 2026 13:34
Copilot AI lite review requested due to automatic review settings August 5, 2026 13:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Ready to approve

The change correctly enforces mutually exclusive GA/EA filtering and adds targeted regression tests (including mixed boolean/string ea metadata) covering the reported failure mode.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR fixes SapMachine early-access (EA) selection so that EA requests cannot resolve stable (GA) builds, aligning SapMachine filtering behavior with how -ea versions are normalized in the base installer.

Changes:

  • Make SapMachine GA vs EA candidate filtering mutually exclusive by classifying ea metadata into a boolean isEarlyAccess and filtering via the request’s stable flag.
  • Expand SapMachine manifest typing to accept both boolean and string forms of the ea field.
  • Add regression coverage with a deterministic fixture containing competing GA and EA candidates, and regenerate the bundled dist/ output.
File summaries
File Description
src/distributions/sapmachine/models.ts Updates manifest typing to support ea as `boolean
src/distributions/sapmachine/installer.ts Implements symmetric GA/EA filtering via isEarlyAccess classification.
tests/distributors/sapmachine-installer.test.ts Adds fixture-backed tests to ensure EA requests never pick stable builds and validates mixed ea field encodings.
tests/data/sapmachine-release-classes.json New deterministic manifest fixture with competing GA/EA candidates and mixed ea representations.
dist/setup/557.index.js Regenerated distribution bundle reflecting the SapMachine filtering fix.
Review details
  • Files reviewed: 4/5 changed files
  • Comments generated: 0
  • Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

jdubois and others added 4 commits August 5, 2026 15:38
@brunoborges
brunoborges merged commit 5580b78 into actions:main Aug 5, 2026
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SapMachine EA requests can select stable releases

3 participants