Fix SapMachine early-access filtering - #1217
Merged
brunoborges merged 6 commits intoAug 5, 2026
Merged
Conversation
Ensure SapMachine EA requests exclude stable releases and cover string and boolean release metadata with competing fixture candidates.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Regenerate the setup bundle for SapMachine release-class filtering.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Ready to approve
The change correctly enforces mutually exclusive GA/EA filtering and adds targeted regression tests (including mixed boolean/string ea metadata) covering the reported failure mode.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR fixes SapMachine early-access (EA) selection so that EA requests cannot resolve stable (GA) builds, aligning SapMachine filtering behavior with how -ea versions are normalized in the base installer.
Changes:
- Make SapMachine GA vs EA candidate filtering mutually exclusive by classifying
eametadata into a booleanisEarlyAccessand filtering via the request’sstableflag. - Expand SapMachine manifest typing to accept both boolean and string forms of the
eafield. - Add regression coverage with a deterministic fixture containing competing GA and EA candidates, and regenerate the bundled
dist/output.
File summaries
| File | Description |
|---|---|
| src/distributions/sapmachine/models.ts | Updates manifest typing to support ea as `boolean |
| src/distributions/sapmachine/installer.ts | Implements symmetric GA/EA filtering via isEarlyAccess classification. |
| tests/distributors/sapmachine-installer.test.ts | Adds fixture-backed tests to ensure EA requests never pick stable builds and validates mixed ea field encodings. |
| tests/data/sapmachine-release-classes.json | New deterministic manifest fixture with competing GA/EA candidates and mixed ea representations. |
| dist/setup/557.index.js | Regenerated distribution bundle reflecting the SapMachine filtering fix. |
Review details
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Apply the repository Prettier format to the focused test additions.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eametadataValidation
Closes #1216